What's wrong with this script?

on open pic_folder
		tell application "Finder"
			set container_ to container of item 1 of pic_folder
			if exists alias ((container_ as text) & "Newspaper Pics ") then
				set news_pic to make new folder at container_
				set news_pic to make new folder at pic_folder with properties {name:"Newspaper Pics"}
			end if
		end tell
	on error errMsg
		display dialog errMsg
	end try
	tell application "GraphicConverter"
		repeat with image_files in pic_folder
				open (image_files as text)
				if (count of items of image_files) is not 0 then
					repeat with i from 1 to (count of items of image_files)
						set this_pic to item i of image_files
						set win to (a reference to front window)
						tell win
							scale horizontal 0.5 vertical 0.5
							set color space to grayscale
							save win in (news_pic) as TIFF
							close win
						end tell
					end repeat
				end if
			on error e
				display dialog e
			end try
		end repeat
	end tell
	tell application "Finder"
		quit application "GraphicConverter"
		display dialog "Whew! It's done." buttons {"OK"} default button "OK"
	end tell
end open

I just need to know what I need to do to fix it.

Thx in advance! :smiley:


You can save the following script as an app or just run it from the Script Editor. If saved as an application, just drag and drop your source folder on it to kick it off. I’m not sure how GraphicConverter treats folders but it seems you need to list the files of the folder and then loop through those. I’ve added code that lists the folder and processes all the files in the folder (skipping folders). If a file is not an image type GC can read, you will get a dialog telling you so but the script should continue.


That works! YAY!!!

Thx a bunch jonn! :smiley: